fix(extensions): resolve __SPECKIT_COMMAND tokens in auto-registered skills#3544
Merged
mnriem merged 4 commits intoJul 16, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Resolves explicit command-reference tokens while generating extension skills.
Changes:
- Resolves
__SPECKIT_COMMAND_*__tokens using the configured separator. - Tests token resolution and preservation of literal references.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/extensions/__init__.py |
Adds token resolution to skill generation. |
tests/test_extension_skills.py |
Adds regression tests for generated skill content. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Medium
Collaborator
|
Please address Copilot feedback. I would assume for those other integrations you will need to override the method that generates the actual content? |
Resolve extension skill command-reference tokens with the active skill invocation style so Codex and ZCode use $speckit-* while slash-style agents keep their native forms. Preserve literal command-looking text.
Contributor
Author
|
Addressed the feedback by making extension skill command-reference tokens render with the active agent invocation style, including |
mnriem
requested changes
Jul 15, 2026
mnriem
left a comment
mnriem
left a comment
Collaborator
There was a problem hiding this comment.
Please address Copilot feedback
mnriem
self-requested a review
July 16, 2026 12:20
mnriem
approved these changes
Jul 16, 2026
5 tasks
mnriem
added a commit
to davidebibm/spec-kit
that referenced
this pull request
Jul 16, 2026
…separators, extension-skill token resolution Addresses PR review 4716036212 (3 comments): 1. Bob legacy-install regression: `use`/`switch`/`upgrade` on an existing Bob 1.x project (only `.bob/commands/` on disk, no stored `legacy_commands`) called `is_skills_mode(None)` -> True and rewrote `ai_skills=True`, silently switching extension/command-reference handling to the skills layout. `is_skills_mode` now takes an optional `project_root`; Bob preserves an already-installed legacy layout until an explicit upgrade creates `.bob/skills/`. A fresh project still defaults to skills. 2. Copilot dual-mode separator: `invoke_separator_for_mode` was inherited from the base (mode-independent) and returned Copilot's static `.`, so preset/extension command refs in a Copilot skills project rendered `/speckit.<name>` instead of `/speckit-<name>`. Override it on Copilot to track the persisted `ai_skills` state, consistent with `build_command_invocation` and `effective_invoke_separator`. 3. Bob extension-skill command-ref tokens: verified that merging main's generic `_resolve_command_ref_tokens` (github#3544) resolves Bob's tokens via the `CONDITIONAL_SLASH_AGENTS` path (`/speckit-<name>`); added Bob to the command-ref regression parametrize plus dedicated Bob use-path tests. All tests pass (full suite green; merged with current main incl. github#3544). Assisted-by: GitHub Copilot (model: Claude Opus 4.8, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 63f93544-a77f-4f01-bf04-c88806a97dbf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolve explicit
__SPECKIT_COMMAND_<NAME>__tokens when extension commands are rendered into generatedSKILL.mdfiles.This updates the extension skill-registration path to call
IntegrationBase.resolve_command_refs(...)afterresolve_skill_placeholders()and before integration-specific skill post-processing, matching the existing command-rendering pipeline.Scope is limited to explicit
__SPECKIT_COMMAND_*__tokens for #3451 phase 2. It does not rewrite literal/speckit.foo.barorspeckit.foo.bartext.Refs #3451
Testing
git diff --check.venv/bin/python -m pytest tests/test_extension_skills.py -q.venv/bin/python -m pytest tests/test_agent_config_consistency.py -k 'skills_agent_command_token_resolves_with_hyphen' -q